Persist TGT and ST obtained during kerberosLogin#2193
Open
azoxlpf wants to merge 1 commit into
Open
Conversation
Contributor
|
What about also writing them to the CCache if specified? (see #2121 ) |
Contributor
Author
|
For this PR I’d keep it minimal: persist Automatic ccache writes feel like a separate, opt-in change (e.g. when |
anadrianmanrique
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion on NetExec #1239 with @NeffIsBack, this PR persists the TGT and ST that
kerberosLogin/kerberos_loginalready obtain internally (getKerberosTGT / getKerberosTGS) intoself.__TGTandself.__TGS, instead of discarding them after building the SMBAP_REQ. Callers can then retrieve those tickets via the existinggetCredentials()API after a successful Kerberos login (e.g. to write a ccache with NetExec’s--generate-st/--generate-tgtwithout running a second KDC exchange). Changes apply to both smb.py (SMB1) and smb3.py (SMB2/3).